server: check guest os preference of last host when start a vm#4338
Conversation
| } else { | ||
| s_logger.debug("The last host of this VM does not have enough capacity"); | ||
| } | ||
| } else { |
There was a problem hiding this comment.
Any reason to delete this log? Better to display if either tags or the guest os preference mismatches right?
There was a problem hiding this comment.
@ravening it is moved to method checkVmProfileAndHost line 573
https://github.com/apache/cloudstack/pull/4338/files#diff-33d8e6144eebe797af78210131747498R573
|
@blueorangutan package |
|
@DaanHoogland a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. |
|
Packaging result: ✔centos7 ✖centos8 ✔debian. JID-2073 |
|
@blueorangutan test |
|
@DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests |
|
LGTM |
|
Trillian test result (tid-2846)
|
6 participants
Description
If vm has last host_id specified, cloudstack will try to start vm on it at first.
However, host tag is checked, but guest os preference is not checked.
for new vm, it will be deployed to the preferred host as we expect.
Fixes: #3554 (comment)
Types of changes
Screenshots (if appropriate):
How Has This Been Tested?